[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#40207] [PATCH 2/2] tests: install: Add %test-gui-installed-desktop-
[bug#40207] [PATCH 2/2] tests: install: Add %test-gui-installed-desktop-os-encrypted.
Wed, 25 Mar 2020 22:41:11 +0100
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
Mathieu Othacehe <address@hidden> skribis:
>> What about making a separate OS definition for the desktop installation
>> case? We’d move the ‘os’ variable to the top-level and add an ‘os’
>> parameter to ‘guided-installation-test’.
>> Having two separate OS definitions (one for desktop install, one for
>> “bare-bones” install) should be clearer than having a single definition
>> with conditionals.
> I fixed all your remarks. But there's still an issue, the size of the
> installation image is guessed badly in "run-install" for
> (image (system-disk-image
> os (list target))
> #:disk-image-size 'guess ;guess is too low.
> applying the dirty snippet below fixes it, but you may have a better idea?
> --- a/gnu/build/vm.scm
> +++ b/gnu/build/vm.scm
> @@ -233,7 +233,7 @@ deduplicates files common to CLOSURE and the rest of
> "Return the estimated size of a partition that can store the store items
> given by GRAPHS, a list of file names produced by #:references-graphs."
> ;; Simply add a 25% overhead.
> - (round (* 1.25 (closure-size graphs))))
> + (round (* 1.30 (closure-size graphs))))
Weird, the 25% hack had always worked fine.
I don’t have a better idea though. Perhaps it’s better to pass an
explicit size in ‘run-install’ than to modify the 25% hack above?
[bug#40207] [PATCH 1/2] installer: tests: Use a filter to select desktop-environments., Ludovic Courtès, 2020/03/24