[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#40289] [PATCH] games.scm: add "neverball" and "neverputt" (bundled

From: Nicolas Goaziou
Subject: [bug#40289] [PATCH] games.scm: add "neverball" and "neverputt" (bundled together)
Date: Mon, 30 Mar 2020 14:31:16 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)


Vitaliy Shatrov via Guix-patches via <address@hidden> writes:

> gnu/packages/games.scm:
>   Added:
>     *  a game neverball and it's "addon", neverputt.
>     *  the #:use-module "copy-build-system".

Thank you! Somme comments follow

> Subject: [PATCH] games.scm:  add "neverball" and "neverputt" (bundled
>  together).
> gnu/packages/games.scm:
>   Added:
>     *  a game neverball and it's "addon", neverputt.
>     *  the #:use-module "copy-build-system".

The commit message should be

    gnu: Add neverball

    * gnu/packages/games.scm (neverball): New variable.

That's it.
> +      (source (origin

Nitpick: I suggest to move `origin' on the line below `source'.

> +                 ;; Debian doesn't strip it, though.  i'm dummy
> +                 (delete-file-recursively "data/ball/octocat"))

Usually, we would delete it in a snippet so "guix build -S neverball"
returns source without the problematic part. Could you do it?

> +           (add-after 'install 'install-icons

Could this be moved within the install plan?

> +      (description
> +       "Also included is Neverputt, which is a 3D miniature golf
> game.

The first sentence should be complete.

> +In the grand tradition of Marble Madness and Super Monkey Ball,
> +Neverball has you guide a rolling ball through dangerous territory.
> +Balance on narrow bridges, navigate mazes, ride moving platforms, and
> +dodge pushers and shovers to get to the goal.  Race against the clock to
> +collect coins to earn extra balls.") ;; mouse on sway cause crash

The last comment seems out of place. This may need to be reported
upstream instead.

Also, note that end of line comments are expected to start with a single
semicolon. Double semicolon comments start at the beginning of the line


Nicolas Goaziou

reply via email to

[Prev in Thread] Current Thread [Next in Thread]