[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#40304] [PATCH] gnu: Add emacs-dhall-mode.
From: |
Nicolas Goaziou |
Subject: |
[bug#40304] [PATCH] gnu: Add emacs-dhall-mode. |
Date: |
Mon, 30 Mar 2020 19:24:34 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello,
John Soo <address@hidden> writes:
> dhall-mode provides language support for the dhall configuration
> language.
Thank you.
> +(define-public emacs-dhall-mode
> + (package
> + (name "emacs-dhall-mode")
> + (version "0.1.0")
This version is not accurate. The ".el" file mentions 0.1.3, but I think
we should use Github versioning, i.e., there is no versioning at all, so
we should do the commit + revision dance again, and use "0.1.3" as the
base of the version string.
> + (source
> + (origin
> + (method git-fetch)
> + (uri
> + (git-reference
> + (url "https://github.com/psibi/dhall-mode")
> + (commit "ef4d33debe224c6ba37e51a29b9dc8b74f20f1c2")))
This should go in a dedicated variable.
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "1232y2k4l3bsz90pgis78zxmrw7jv09dfaip21yc1w4vpxfyr384"))))
Nitpick: I usually put `base32' on the same line as the string.
> + (inputs
Nitpick: Emacs build system uses `propagated-inputs', although this is
the same.
> + `(("emacs-reformatter" ,emacs-reformatter)))
> + (build-system emacs-build-system)
Nitpick: `build-system' is usually above
> + (home-page "https://github.com/psibi/dhall-mode")
> + (synopsis "Major mode for working with Dhall configuration language")
> + (description
> + "Emacs Major mode for working with Dhall configuration
> language.")
The description must be a full sentence.
> + (license license:gpl2+)))
The license looks wrong. I see GPL3+ in this package.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou