[bug#40767] [PATCH] gnu: Add maradns.

[Mathieu Othacehe]

> guix lint checks for lines longer than 90 characters. Perhaps that's the
> new policy? See the function report-long-line in guix/lint.scm. It even
> has a comment noting that we don't warn at 80 characters.

Yes it's to avoid false positives with hashes and URLs. On the other
hand, in .dir-locals.el, fill-column variable is set to 78. Maybe we
would need to be more explicit in the "Coding style" section of the
manual.

> -           (lambda _
> +           (lambda* (#:key native-inputs #:allow-other-keys)
> +             ;; make_32bit_tables generates a header file that is used during
> +             ;; compilation. Hence, during cross compilation, it should be
> +             ;; built for the host system.
> +             (when ,(%current-target-system)
> +               (substitute* "rng/Makefile"
> +                 (("\\$\\(CC\\) -o make_32bit_tables")
> +                  (string-append (assoc-ref native-inputs "gcc")
> +                                 "/bin/gcc -o make_32bit_tables"))))

Nitpicking, you can use the target argument instead of
%current-target-system, this way:

--8<---------------cut here---------------start------------->8---
(lambda* (#:key native-inputs target #:allow-other-keys)
         ;; make_32bit_tables generates a header file that is used during
         ;; compilation. Hence, during cross compilation, it should be
         ;; built for the host system.
         (when target
           (substitute* "rng/Makefile"
                        (("\\$\\(CC\\) -o make_32bit_tables")
                         (string-append (assoc-ref native-inputs "gcc")
                                        "/bin/gcc -o make_32bit_tables")))))
--8<---------------cut here---------------end--------------->8---

Feel free to go ahead with this one,

Thanks,

Mathieu