[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#40947] Add emacs-boon
From: |
Nicolas Goaziou |
Subject: |
[bug#40947] Add emacs-boon |
Date: |
Wed, 29 Apr 2020 16:48:02 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hello,
Elais Player <address@hidden> writes:
> This patch adds the boon modal editing package
Thank you.
> Subject: [PATCH 1/1] Add emacs-boon package
>
> This patch adds boon modal editing packages.
The expected commit message is slightly different.
gnu: Add emacs-boon.
* gnu/packages/emacs-xyz.scm (emacs-boon): New variable.
If you use Yasnippets, using "add <TAB>" in an empty commit message
generates it for you. See (info "(guix)The Perfect Setup").
> provides a simple but convenient user interface to manage those trashed
> files.")
> (license license:gpl3+)))
As a rule of thumb, please do not append new packages at the end of the
file. It is more likely to generate merge conflicts.
> + (sha256
> + (base32
> + "1ss9bjs34q41pa0g0nbdzd8fwpjcbd2239rdlx5aykfv9v0b8j77"))))
Nitpick: could you move the string on the same line as `base32'?
> + (build-system emacs-build-system)
> + (propagated-inputs
> + `(("emacs-expand-region" ,emacs-expand-region)
> + ("spaceline" ,emacs-spaceline)
> + ("powerline" ,emacs-powerline)
> + ("emacs-dash" ,emacs-dash)
> + ("emacs-multiple-cursors" ,emacs-multiple-cursors)))
Could you re-order inputs alphabetically?
> + (home-page "https://github.com/jyp/boon")
> + (synopsis "Ergonomic Command Mode for Emacs.")
Synopsis is not expected to end with a full stop. You may want to run
guix lint on the package.
> + (description
> + "Boon brings modal editing capabilities to Emacs and...
> +
> +- It tries to be as ergonomic as possible.
> +- It remains lightweight (~300 loc for its core.)
> +- It attempts to integrate with Emacs as smoothly as possible")
Here you should write Texinfo markup:
@itemize
@item it tries to...
@item ...
...
@end itemize
However, you way want to extract the description from the project's
GitHub front page instead of the main file.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou