bug#41167: V2 Re: [bug#41167] [PATCH 5/5] gnu: Add julia-compat.

[Ludovic Courtès]

Hi Nicolò,

Nicolò Balzarotti <address@hidden> skribis:

>> Hello!
>>
>> nixo <address@hidden> skribis:
>>
>>> * julia-xyz.scm: New file.
>>> * local.mk: Add julia-xyz.scm to it.
>>> * julia-xyz.scm (julia-compat): New variable.
>>
>> Please spell out file names; you can also remove the last line, not
>> needed here since it’s a new file.
>>
>>> --- /dev/null
>>> +++ b/gnu/packages/julia-xyz.scm
>>> @@ -0,0 +1,27 @@
>>> +(define-module (gnu packages julia-xyz)
>>
>> Could you add the license/copyright header and resend this one?
>>
>> I’ll see if I can apply the whole series and build it tomorrow.
>>
> Prepare for a long build time!  Running tests takes like 4 hours.

Ouch, indeed.  It went fine though!

I pushed the whole series.  Note that I modified the patch-adjusting
patch to preserve the comment that was originally there.

Nitpick: for future patches, I recommend avoiding “Fix …” in the subject
line, unless (1) there’s a bug report and the commit log links to it, or
(2) the commit log explains what’s being fixed.  (It wasn’t clear to me
whether the first two patches were “fixing” something that didn’t work
at all, and to what extent.)

Anyway, thumbs up for the upgrade!  \o/

Thanks,
Ludo’.