guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#40557] [PATCH] Add dhall.


From: John Soo
Subject: [bug#40557] [PATCH] Add dhall.
Date: Fri, 29 May 2020 06:40:11 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)

Hello,

Leo Famulari <leo@famulari.name> writes:

> Thanks! The first 24 patches LGTM as-is.

Thank you.

>> * gnu/packages/dhall.scm (dhall): New variable.
>> * gnu/local.mk (GNU_SYSTEM_MODULES): Add dhall.scm.
>> * gnu/packages/patches/dhall-remove-network-tests.patch: Add patch to remove
>>   network tests.
>
>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         (add-after 'unpack 'remove-more-tests
>
> Can you add a brief comment explaining why we need to remove these
> tests, rename the phase to reflect that, and send a revised patch?

Alright, done.  Let me know what else I can do.

Thanks again!

- John

Attachment: 0001-gnu-Add-ghc-inspection-testing.patch
Description: Text Data

Attachment: 0002-gnu-Add-ghc-data-fix.patch
Description: Text Data

Attachment: 0003-gnu-Add-ghc-cborg.patch
Description: Text Data

Attachment: 0004-gnu-Add-ghc-cborg-json.patch
Description: Text Data

Attachment: 0005-gnu-Add-ghc-dotgen.patch
Description: Text Data

Attachment: 0006-gnu-Add-ghc-generic-random.patch
Description: Text Data

Attachment: 0007-gnu-Add-ghc-text-manipulate.patch
Description: Text Data

Attachment: 0008-gnu-Add-ghc-spoon.patch
Description: Text Data

Attachment: 0009-gnu-Add-ghc-special-values.patch
Description: Text Data

Attachment: 0010-gnu-Add-ghc-serialise.patch
Description: Text Data

Attachment: 0011-gnu-Add-ghc-pretty-simple.patch
Description: Text Data

Attachment: 0012-gnu-Add-ghc-pgp-wordlist.patch
Description: Text Data

Attachment: 0013-gnu-Add-ghc-optional-args.patch
Description: Text Data

Attachment: 0014-gnu-Add-ghc-turtle.patch
Description: Text Data

Attachment: 0015-gnu-Add-ghc-managed.patch
Description: Text Data

Attachment: 0016-gnu-Add-ghc-lens-family-core.patch
Description: Text Data

Attachment: 0017-gnu-Add-ghc-prettyprinter.patch
Description: Text Data

Attachment: 0018-gnu-Add-ghc-repline.patch
Description: Text Data

Attachment: 0019-gnu-Add-ghc-haskeline-0.8.patch
Description: Text Data

Attachment: 0020-gnu-Add-ghc-repline-0.3.patch
Description: Text Data

Attachment: 0021-gnu-Add-ghc-prettyprinter-1.6.patch
Description: Text Data

Attachment: 0022-gnu-Add-ghc-prettyprinter-ansi-terminal.patch
Description: Text Data

Attachment: 0023-gnu-Add-ghc-generic-random-1.3.0.1.patch
Description: Text Data

Attachment: 0024-gnu-Add-ghc-atomic-write-0.2.0.7.patch
Description: Text Data

Attachment: 0025-gnu-Add-dhall.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]