guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#41151: [PATCH] gnu: vis: Fix #39394


From: Jakub Kądziołka
Subject: bug#41151: [PATCH] gnu: vis: Fix #39394
Date: Mon, 1 Jun 2020 15:44:13 +0200

On Sat, May 09, 2020 at 03:51:53PM +0000, tsmish wrote:
> There is no need to set $VIS_PATH to $prefix/share/vis as VIS_PATH
> (#define), which is also in search path
> (https://github.com/martanne/vis/blob/7648280a95954304e5e935e2cead16d836b86eda/vis-lua.c#L2662),
> is already set by Makefile to $prefix/share/vis
> (https://github.com/martanne/vis/blob/7648280a95954304e5e935e2cead16d836b86eda/Makefile#L37).

Thanks for the patch! We usually avoid putting a bug number as the only
information in the commit title, so I took the liberty to rewrite the
commit message a bit:

commit 5b588f2c9ba9c40dc32aed7c3cdaa45e8f920509 (HEAD -> master, 
upstream/master)
Author: tsmish <tsymsh@gmail.com>
Date:   Sat May 9 15:51:53 2020 +0000

    gnu: vis: Fix configuration load order.

    * gnu/packages/text-editors.scm (vis)[native-search-paths]: Remove.

    There is no need to set $VIS_PATH to $prefix/share/vis as VIS_PATH
    (#define), which is also in search path
    
(https://github.com/martanne/vis/blob/7648280a95954304e5e935e2cead16d836b86eda/vis-lua.c#L2662),
    is already set by Makefile to $prefix/share/vis
    
(https://github.com/martanne/vis/blob/7648280a95954304e5e935e2cead16d836b86eda/Makefile#L37).

    This fixes issue https://issues.guix.gnu.org/39394

    Signed-off-by: Jakub Kądziołka <kuba@kadziolka.net>

Cheers!

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]