[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#41767] [PATCH 9/9] DROP? channels: Add prehistorical authorizations
[bug#41767] [PATCH 9/9] DROP? channels: Add prehistorical authorizations to <channel-introduction>.
Tue, 09 Jun 2020 14:35:57 -0400
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
Ludovic Courtès <email@example.com> writes:
> This allows users to authenticate commits that were made before
> '.guix-authorizations' was introduced.
> * guix/channels.scm (<channel-introduction>)[prehistorical-authorizations]:
> New field.
> (%guix-historical-committers): New variable.
> (openpgp-fingerprint->bytevector): New procedure.
> (%guix-channel-introduction): Add 'prehistorical-authorizations' field.
> (authenticate-channel): Honor it. Pass it as #:default-authorizations
> to 'authenticate-commits'.
> * build-aux/git-authenticate.scm (%historical-committers)
> (%historical-authorized-signing-keys, commit-short-id): Remove.
> * build-aux/git-authenticate.scm (git-authenticate): Rewrite to use
> * tests/channels.scm ("authenticate-channel, wrong first commit signer")
> ("authenticate-channel, .guix-authorizations"): Adjust accordingly.
I'd be in favor of dropping this commit, to not be burdened by legacy
complexity, which I'm doubtful would see much use anyway. This means
that a channel require all its commits to have a .guix-authorizations
file to be authenticated. I think that's fine.
The series LGTM. I haven't tested it locally, but the tests give me
Thank you for working on this!
[bug#41767] [PATCH 3/9] tests: Move OpenPGP helpers to (guix tests gnupg)., Ludovic Courtès, 2020/06/08
[bug#41767] [PATCH 6/9] .guix-channel: Add 'keyring-reference'., Ludovic Courtès, 2020/06/08
[bug#41767] [PATCH 8/9] pull: Add '--disable-authentication'., Ludovic Courtès, 2020/06/08
[bug#41767] [PATCH 5/9] channels: Make 'validate-pull' call right after clone/pull., Ludovic Courtès, 2020/06/08
[bug#41767] [PATCH 0/9] Authenticate channels, Ludovic Courtès, 2020/06/09
[bug#41767] [PATCH 0/9] Authenticate channels, zimoun, 2020/06/09