[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#41767] [PATCH 9/9] DROP? channels: Add prehistorical authorizations

From: Maxim Cournoyer
Subject: [bug#41767] [PATCH 9/9] DROP? channels: Add prehistorical authorizations to <channel-introduction>.
Date: Tue, 09 Jun 2020 14:35:57 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)


Ludovic Courtès <> writes:

> This allows users to authenticate commits that were made before
> '.guix-authorizations' was introduced.
> * guix/channels.scm (<channel-introduction>)[prehistorical-authorizations]:
> New field.
> (%guix-historical-committers): New variable.
> (openpgp-fingerprint->bytevector): New procedure.
> (%guix-channel-introduction): Add 'prehistorical-authorizations' field.
> (authenticate-channel): Honor it.  Pass it as #:default-authorizations
> to 'authenticate-commits'.
> * build-aux/git-authenticate.scm (%historical-committers)
> (%historical-authorized-signing-keys, commit-short-id): Remove.
> * build-aux/git-authenticate.scm (git-authenticate): Rewrite to use
> 'authenticate-channel'.
> * tests/channels.scm ("authenticate-channel, wrong first commit signer")
> ("authenticate-channel, .guix-authorizations"): Adjust accordingly.

I'd be in favor of dropping this commit, to not be burdened by legacy
complexity, which I'm doubtful would see much use anyway.  This means
that a channel require all its commits to have a .guix-authorizations
file to be authenticated.  I think that's fine.

The series LGTM.  I haven't tested it locally, but the tests give me

Thank you for working on this!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]