[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#41293] [PATCH 1/3] gnu: Add sideload.
From: |
Marius Bakke |
Subject: |
[bug#41293] [PATCH 1/3] gnu: Add sideload. |
Date: |
Mon, 22 Jun 2020 21:16:54 +0200 |
Hello!
Sorry for the slooow response...
Ryan Prior via Guix-patches via <guix-patches@gnu.org> writes:
> * gnu/packages/pantheon.scm (sideload): New variable.
[...]
> + (modify-phases %standard-phases
> + (add-before 'install 'set-environment-variables
> + (lambda _
> + ;; Disable compiling schemas and updating desktop databases
> + (setenv "DESTDIR" "/")
> + #t))
That's an unorthodox workaround :-) does the build system ignore it when
DESTDIR is set, or do they just end up in a different location?
Is the "glib:bin" input still needed?
> + (inputs
> + `(("flatpak" ,flatpak)
> + ("granite" ,granite)
> + ("gtk" ,gtk+)
> + ("libostree" ,libostree)))
> + (propagated-inputs
> + `(("glib-networking" ,glib-networking)))
Can you add a comment about why this needs to be propagated?
> + (native-inputs
> + `(("cmake" ,cmake)
Use 'cmake-minimal' if CMake is required (is it?).
> + ("gettext" ,gettext-minimal)
> + ("glib" ,glib)
> + ("glib:bin" ,glib "bin")
> + ("gobject-introspection" ,gobject-introspection)
> + ("libgee" ,libgee)
> + ("libxml2" ,libxml2)
> + ("pkg-config" ,pkg-config)
> + ("vala" ,vala)))
> + (home-page "https://github.com/elementary/sideload")
> + (synopsis "Graphical application to side-load Flatpaks")
> + (description "Sideload handles flatpakref files, like those you might
> find
> +on Flathub or another third-party website providing a Flatpak app for
> +download.")
> + (license license:gpl3)))
This should be 'gpl3+' because no source files say "GPL 3 only" (in fact
they explicitly mention GPL 3 or any later version).
signature.asc
Description: PGP signature