[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#41574] gnu: Add intel-xev.
From: |
elaexuotee |
Subject: |
[bug#41574] gnu: Add intel-xev. |
Date: |
Tue, 23 Jun 2020 15:04:06 +0900 |
User-agent: |
mblaze/0.7 |
Marius,
Thanks for taking a look at this.
> Were these two downgrades intended? I'm assuming no, since the new
> package don't appear to use them.
Definitely not. Looks like I was sloppy with a local rebase. Thanks for
catching this.
> Does it work to use 'python-wrapper' instead of providing both Python 2
> and Python 3 here?
Beautiful; 'python-wrapper' is exactly what I was looking for.
> Is the src output used for other things than documentation? If not, I
> think we can drop it and let users do 'guix build --source intel-xed'
> instead. The description should be modified accordingly.
Sounds emminently reasonable to me.
> Apart from this the package LGTM. Probably it should have:
>
> (supported-systems '("x86_64-linux" "i686-linux"))
>
> too?
I'm not so sure, actually. The tool and library simply facilitate translating
to/from x86 opcodes, but as far as I can tell it doesn't actually *execute* any
architecture-specific instructions.
> Can you add a short description at the top of the patch file explaining
> what it does any why?
Oh, neat. I didn't know this was possible.
> Can you send an updated patch? Thanks!
Done!
0001-gnu-Add-intel-xed.patch
Description: Text Data
signature.asc
Description: PGP signature