[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#42019] [PATCH 1/1] website: Add integrity to JSON sources.
From: |
Ludovic Courtès |
Subject: |
[bug#42019] [PATCH 1/1] website: Add integrity to JSON sources. |
Date: |
Sat, 27 Jun 2020 19:05:50 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hi!
zimoun <zimon.toutoune@gmail.com> skribis:
> * website/apps/packages/builder.scm (origin->json): Add integrity field using
> SRI format.
[...]
> - `(("url" . ,(list->vector
> + `(("urls" . ,(list->vector
> (resolve
> (match uri
> ((? string? url) (list url))
Is this change OK for Repology? Or should we keep “url” in addition to
“urls”?
> (make-page "sources.json"
> `(("sources" . ,(list->vector (map package->json
> (all-packages))))
> - ("version" . "1"))
> + ("version" . "1")
> + ("revision" . ,%guix-version))
There’s no guarantee that ‘%guix-version’ is a commit ID, so perhaps we
should do something like:
(match (current-profile)
(#f %guix-version) ;for lack of a better ID
(profile
(let ((channel (find guix-channel? (profile-channels profile))))
(channel-commit channel))))
Otherwise LGTM, thank you!
Ludo’.
[bug#42019] [PATCH v2] website: Add integrity to JSON sources., zimoun, 2020/06/29