guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#42082] [PATCH 1/6] gnu: Add python-covdefaults.


From: Vinicius Monego
Subject: [bug#42082] [PATCH 1/6] gnu: Add python-covdefaults.
Date: Tue, 21 Jul 2020 15:28:40 -0300
User-agent: Evolution 3.30.5-1.1

Em seg, 2020-07-20 às 23:13 +0200, Marius Bakke escreveu:
> Hi Vinicius,

Hello Marius,

Thanks for the tips!

> We now have a 'python-check.scm' which is preferable to
> check.scm.  Can
> you add this library there instead?

Sure. I overlooked that file. I sent another series of 6 pytest patches
before this, and will send a v2 for that as well.

> Should pytest be propagated here?
> 
> Also, as this package is a plugin for coverage, maybe it should not
> propagate coverage either.  The reason is that propagating prevents
> it
> from being (easily) used with other versions of coverage.  Let's say
> that a package needs a newer coverage than the default in Guix + this
> plugin, propagation here would bring in the wrong coverage version.

Oh, I thought that the pytest binary should be available as an
executable for the plugin to be used, similar to how APT has pytest as
a dependency for plugins. Maybe it's just me thinking in terms of
traditional package management.

The PyPI importer will propagate pytest by default, and it's common to
see it propagated in other plugins in check.scm. But now I see that
many plugins do not propagate it. Should pytest not be an input at all
(unless the plugin uses it for its own tests, in which case it should
be a native input)?

> I know it's a lot to ask :-) but can you try to expand on how it
> differs
> from the apparently unreasonable defaults in coverage?  "Sensible"
> also
> borders on "marketing speak", perhaps "opinionated" is a better term.

That's a slight rewording of the author's description in the
repository, and that's the only verbal information I could find about
the project. The differences can be seen in the README and in the
source code, but I don't know what to write about them, or even why the
changes are 'more sensible'.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]