[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#43101] [PATCH v2] Add version number in release ISO
From: |
Ludovic Courtès |
Subject: |
[bug#43101] [PATCH v2] Add version number in release ISO |
Date: |
Mon, 31 Aug 2020 14:12:25 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hi!
Julien Lepiller <julien@lepiller.eu> skribis:
> From a502fa70b0230d3f91ddf05410f24a1f4fcad521 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Sat, 29 Aug 2020 15:34:56 +0200
> Subject: [PATCH 1/3] guix: system: Add `--label' option.
>
> * guix/scripts/system.scm (%options): Add `--label'.
> (system-derivation-for-action): Take a #:label key to set volume ID.
> (perform-action): Take a #:label key.
> (%default-options): Add default label value.
> (process-action): Pass label value from command-line to perform-action.
> ---
> doc/guix.texi | 4 +++-
> guix/scripts/system.scm | 27 ++++++++++++++++++++++-----
Please mention the doc/guix.texi changes as well in the log. :-)
> --- a/doc/guix.texi
> +++ b/doc/guix.texi
> @@ -28836,7 +28836,9 @@ the @option{--image-size} option is ignored in the
> case of
> @code{docker-image}.
>
> You can specify the root file system type by using the
> -@option{--file-system-type} option. It defaults to @code{ext4}.
> +@option{--file-system-type} option. It defaults to @code{ext4}. When its
> +value is @code{iso9660}, the @option{--label} option can be used to specify
> +a volume ID with @code{disk-image}.
Could you also add an @item for --label, just like we have for the other
options?
I’m also fine with what Mathieu suggests.
OK for me with changes along these lines!
Thank you,
Ludo’.
- [bug#43101] [PATCH] Add version number in release ISO, Julien Lepiller, 2020/08/29
- [bug#43101] [PATCH] Add version number in release ISO, Ludovic Courtès, 2020/08/30
- [bug#43101] [PATCH] Add version number in release ISO, Julien Lepiller, 2020/08/30
- [bug#43101] [PATCH] Add version number in release ISO, Mathieu Othacehe, 2020/08/30
- [bug#43101] [PATCH] Add version number in release ISO, Julien Lepiller, 2020/08/30
- [bug#43101] [PATCH v2] Add version number in release ISO, Julien Lepiller, 2020/08/30
- [bug#43101] [PATCH v2] Add version number in release ISO, Mathieu Othacehe, 2020/08/31
- bug#43101: [PATCH v2] Add version number in release ISO, Julien Lepiller, 2020/08/31
- [bug#43101] [PATCH v2] Add version number in release ISO,
Ludovic Courtès <=