[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#43183] [PATCH] gnu: Add loko-scheme.

From: Mathieu Othacehe
Subject: [bug#43183] [PATCH] gnu: Add loko-scheme.
Date: Fri, 04 Sep 2020 08:43:37 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Hello Martin,

Thanks for this patch.

> +(define pfds
> +  (let ((name "pfds")
> +     (version "0.3"))
> +      (origin
> +     (method git-fetch)

There's a space/tab indentation mix here and in the other origin

> +     (uri (git-reference
> +           (url "";)
> +           (commit (string-append "v" version))))

This could be useful not only for Loko but also for other scheme
implementations. Thus, it would be nice to define it as a proper package
rather than a simple origin.

> +              (sha256 (base32 
> "019jlh3lywy912cfz689c9fxgf4bi5700i9k04g7sl5w5gchj36m"))

This is usually wrapped to stay under the 78 columns limit.

> +              (file-name (git-file-name name version))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:tests? #f

You should add a comment explaining why tests are disabled.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]