[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#43193] [PATCH] guix: Add --with-dependency-source option

From: Jesse Gibbons
Subject: [bug#43193] [PATCH] guix: Add --with-dependency-source option
Date: Sun, 13 Sep 2020 08:28:50 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Icedove/68.12.0

On 9/13/20 6:55 AM, Ludovic Courtès wrote:

Jesse Gibbons <> skribis:

On 9/11/20 9:43 AM, Ludovic Courtès wrote:

So maybe drop the second clause for non-recursive replacement, and drop
‘transform-package-source’ as well.
I included a fallback to transform-package-source because the
following happens:

$ ./pre-inst-env guix build --with-source=$(guix build --source hello) hello
guix build: error: invalid source replacement specification:

This does not fail when I fall back to the non-recursive logic.

I can drop transform-package-source, but I will need to do some more
hacking to figure out how the package name and version are parsed from
the file name as described in the manual, and move it to the logic in
Yes, that’d be nice.  Namely, if you do:

   guix build hello --source=hello-1.2.3.tar.gz

it should work just as now (from the source file name, we assume that
the source applies to package “hello”).

Conversely, doing:

   guix build hello --source=xyz-hello-1.2.3.tar.gz

would have no effect.  It would not even emit a warning, unlike now.
I was able to get this working nicely.
I'm not going to have as much free time starting next week, so I might
not be able to do that for a while, but I will try to get it done
Sure, let’s stay in touch, I think we’re almost done!

I wrote a new test that checks non-leafs. The following tests fail:

test-name: options->transformation, no transformations
test-name: options->transformation, with-source
test-name: options->transformation, with-source, replacement
test-name: options->transformation, with-source, with version
test-name: options->transformation, with-source, no matches
test-name: options->transformation, with-source, PKG@VER=URI

Some of these tests raise a similar error, some only have a false actual value, and "options->transformation, with-source, no matches" will need to be changed at the test level because it checks for a warning in the output. I've been trying to debug, but the tests don't even give a stack trace. I will do what I can to fix the tests and follow up at the end of the week.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]