[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#41011] [PATCH] gnu: grub: Support for network boot via TFTP.
From: |
Danny Milosavljevic |
Subject: |
[bug#41011] [PATCH] gnu: grub: Support for network boot via TFTP. |
Date: |
Mon, 14 Sep 2020 14:34:25 +0200 |
Hi Stefan,
On Sun, 13 Sep 2020 19:46:01 +0200
Stefan <stefan-guix@vodafonemail.de> wrote:
> diff --git a/gnu/bootloader/grub.scm b/gnu/bootloader/grub.scm
> index e3febeefd0..552bc34f5a 100644
> --- a/gnu/bootloader/grub.scm
> +++ b/gnu/bootloader/grub.scm
> @@ -295,6 +300,9 @@ code."
> ((? file-system-label? label)
> (format #f "search --label --set ~a"
> (file-system-label->string label)))
> + ((? (lambda (device)
> + (and (string? device) (string-contains device ":/"))) nfs-uri)
> + "set root=(tftp)")
> ((or #f (? string?))
> #~(format #f "search --file --set ~a" #$file)))))
After careful consideration, I've pushed this to guix master, with a big
comment in the source code as to why we are doing what we are doing.
I can see no downside to defaulting to TFTP for the time being.
I do wonder if there are cases now where Grub tries to use TFTP when the user
meant to boot locally--but nothing comes to mind.
Thank you for your elaborative E-Mails.
I will still review the remainder. Please take Efraim's comments into
consideration.
pgp3wWichZ7Mg.pgp
Description: OpenPGP digital signature
- [bug#41011] [PATCH] gnu: grub: Support for network boot via TFTP., (continued)
- [bug#41011] [PATCH] gnu: grub: Support for network boot via TFTP., Efraim Flashner, 2020/09/16
- [bug#41011] [PATCH] gnu: grub: Support for network boot via TFTP., Stefan, 2020/09/19
- [bug#41011] [PATCH] gnu: grub: Support for network boot via TFTP., Stefan, 2020/09/20
- [bug#41011] [PATCH] gnu: grub: Support for network boot via TFTP., Stefan, 2020/09/20
- [bug#41011] [PATCH] gnu: grub: Support for network boot via TFTP., Stefan, 2020/09/26
- [bug#41011] [PATCH] gnu: grub: Support for network boot via TFTP., Stefan, 2020/09/26
- [bug#41011] [PATCH] gnu: grub: Support for network boot via TFTP., Danny Milosavljevic, 2020/09/26
- [bug#41011] [PATCH] gnu: grub: Support for network boot via TFTP., Stefan, 2020/09/27
- [bug#41011] [PATCH] gnu: grub: Support for network boot via TFTP., Stefan, 2020/09/27
- [bug#41011] [PATCH] gnu: grub: Support for network boot via TFTP., Danny Milosavljevic, 2020/09/27
- [bug#41011] [PATCH] gnu: grub: Support for network boot via TFTP.,
Danny Milosavljevic <=
- [bug#41011] [PATCH] gnu: grub: Support for network boot via TFTP., Danny Milosavljevic, 2020/09/15