[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#43619] [PATCH 1/2] gnu: Add liburing.
|
From: |
Ludovic Courtès |
|
Subject: |
[bug#43619] [PATCH 1/2] gnu: Add liburing. |
|
Date: |
Tue, 29 Sep 2020 22:38:33 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi Greg,
Greg Hogan <code@greghogan.com> skribis:
>>From 4cd8b67741d61b69e70ae2271b1063f53e3513e8 Mon Sep 17 00:00:00 2001
> From: Greg Hogan <code@greghogan.com>
> Date: Tue, 22 Sep 2020 15:21:43 +0000
> Subject: [PATCH 1/2] gnu: Add liburing.
>
> * gnu/packages/liburing.scm (liburing): New variable.
[...]
> +(define-module (gnu packages liburing)
I would tend to put it in another module, probably (gnu packages linux)
in this case because it’s Linux-specific.
> + (arguments
> + `(#:tests? #f
Please add a comment explaining why the test suite is skipped.
> + (home-page "https://github.com/axboe/liburing";)
> + (synopsis "Simplified interface for io_uring")
Maybe “Interface to the Linux kernel @code{io_uring} interface”?
Could you send an updated patch?
Thanks,
Ludo’.