[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#43769] [PATCH v2 1/2] Add symbolic links for suppo

From: Tobias Geerinckx-Rice
Subject: [bug#43769] [PATCH v2 1/2] Add symbolic links for supported shell completions.
Date: Sat, 03 Oct 2020 21:11:26 +0200


Thanks! Shell code always looks ugly to me, so LGTM if it works :-)

Nitpick: s/create/install/

zimoun 写道:
+ [Nn]*) _msg "${INF}Skipped shell completion installation"
+                   break;;
+            *) _msg "Please answer yes or no.";

Why bother the user with this? We don't ask before installing /etc/profile.d/, or enabling the daemon, and we shouldn't offer similar meaningless choices just for the sake of it.

Kind regards,


Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]