[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#43930] gnu: Add emacs-graphql-mode.
From: |
Nicolas Goaziou |
Subject: |
[bug#43930] gnu: Add emacs-graphql-mode. |
Date: |
Tue, 13 Oct 2020 09:15:36 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hello,
John Soo <jsoo1@asu.edu> writes:
> I've been writing some graphql recently and graphql-mode has been
> invaluable.
Thank you. Some comments follow.
> +(define-public emacs-graphql-mode
> + (let ((commit "9bed568ec86242dbe30bdbab324aa0eb2cd9bf08")
Could you add a comment explaining why you don't use a tagged commit
(in this case, there is none)?
> + (revision "1"))
> + (package
> + (name "emacs-graphql-mode")
> + (version commit)
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/davazp/graphql-mode")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0x9y7qq6y0zg8ncamzvk68ccmdyzh7xsj0xs0ykyl20d5wdpplj4"))))
Nitpick: please move the string on the same line as `base32'.
> + (build-system emacs-build-system)
> + (home-page
> + "https://github.com/davazp/graphql-mode")
Nitpick: please move the string on the same line as `home-page'.
> + (synopsis "Emacs mode to edit GraphQL schema and queries")
> + (description
> + "This package provides an Emacs mode for editing graphql queries and
> +schemas.")
I suggest to expound the description a bit. For example, using
commentary section of the library, it could be something along the lines
of:
This package implements a major mode to edit GraphQL schemas and
query. The basic functionality includes syntax highlight and
indentation. Additionally, it is able to send GraphQL queries to an
end-point URL.
Files with the @file{.graphql} and @file{.gql} extensions are
automatically opened with this mode.
Could you send an updated patch?
Regards,
--
Nicolas Goaziou