[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#43781] [PATCH 2/2] gnu: Add cgoban

From: Ludovic Courtès
Subject: [bug#43781] [PATCH 2/2] gnu: Add cgoban
Date: Thu, 22 Oct 2020 16:55:38 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)


Tomás Ortín Fernández <> skribis:

> Sorry, I see I should have sent it all in one email.
> * gnu/packages/games.scm (cgoban): New variable.

Sorry for the delay!  Some comments:

> +    (arguments
> +     `(#:tests? #t))

Please add a short comment explaining why tests are disabled.

> --- /dev/null
> +++ b/gnu/packages/patches/cgoban-1.9.14-cflags.patch
> @@ -0,0 +1,40 @@
> +--- a/
> ++++ b/

Patches should start with a couple lines stating the origin, their
upstream status, and what they do.

Patches also need to be listed in ‘gnu/’ and mentioned in the
commit log.

However, I suspect this patch has no effect: since ‘autoconf’ is not an
input of the package, its ‘configure’ script cannot be rebuilt to take
those changes into account.

Perhaps you can just remove it?

Could you send a second version?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]