guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#45132] [PATCH 0/2] QC Ren'py package


From: Nicolas Goaziou
Subject: [bug#45132] [PATCH 0/2] QC Ren'py package
Date: Thu, 10 Dec 2020 12:09:36 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Hello,

Leo Prikler <leo.prikler@student.tugraz.at> writes:

> perhaps a bit overdue, the 10th of October marks the anniversary of my
> first contribution to Guix.  A bit later and with a broken git setup,
> I've added a package for Ren'py, which was finally upstreamed towards
> the end of October.

Time flies!

> Today, I am again revisiting that package, as back then there were
> several steps skipped in packaging, that should not have been skipped. 
> The following patch set drops generated sources from both Ren'py and
> its fork of pygame, and also has Ren'py use the already existing
> fribidi package.

It looks good. I suggest adding #t at the end of the snippet as long as
next core-updates merge has not happened.

Could you also mention the origin of the patch (unless it is yours, of
course, in which case you can mention your name)?

Otherwise, LGTM.

Regards,
-- 
Nicolas Goaziou





reply via email to

[Prev in Thread] Current Thread [Next in Thread]