guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#46058] [PATCH] gnu: Test rust-juniper-codegen.


From: Matthew Kraai
Subject: [bug#46058] [PATCH] gnu: Test rust-juniper-codegen.
Date: Sun, 24 Jan 2021 05:06:22 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.6.1

Hi Nicolas,

On 1/24/21 1:20 AM, Nicolas Goaziou wrote:
Hello,

Matthew Kraai <kraai@ftbfs.org> writes:

* gnu/packages/patches/rust-juniper-codegen-use-__private.patch: New file.
* gnu/local.mk (dist_patch_DATA): Add it.
* gnu/packages/crates-io.scm (rust-juniper-codegen-0.14)[source]: Use it.
   [arguments]: Do not set #:tests? to #false.
Thank you for fixing my FIXME. :)

However, I ponder if this is going in the right direction. IIUC, the
goal for Rust packaging is to automatically fetch and build inputs and
development inputs, using the importer, i.e., maybe writing something like

      #:cargo-inputs (("instant" "0.1")
                      ("lock-api" "0.4")
                      ("parking-lot-core" "0.8"))

and let the crate importer deal with it without providing the packages
ourselves.

In this case, why bother, since any non-leaf package will be expected to
#:skip-build anyway. What about doing it here, too?

WDYT?

Regards,

I don't know enough about the long-term goals to know what's best.  Feel free to close this bug if you think that's a better approach.

--
Matthew Kraai






reply via email to

[Prev in Thread] Current Thread [Next in Thread]