[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#45712] [PATCHES] Improve Python package quality
From: |
Maxim Cournoyer |
Subject: |
[bug#45712] [PATCHES] Improve Python package quality |
Date: |
Fri, 29 Jan 2021 09:26:18 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi Lars,
Lars-Dominik Braun <lars@6xq.net> writes:
> Hi Maxim,
>
>> Doesn't that mean that the attrs requirement should be lifted from the
>> bootstrap version? As its purpose is exactly this: breaking the cyclic
>> dependency with itself.
> ah, now I see the problem, there’s a (add-installed-pythonpath inputs
> outputs) missing and so it can’t find the installed packages. Maybe
> we’re working on different branches? I applied your patch directly to
> core-updates.
>
> Cheers,
> Lars
Oh yes, sorry I had failed to mention it, this is on the
cu/farewell-to-pythonpath branch, which is the integration of
GUIX_PYTHONPATH and this work of yours. I've included your v2 patches,
with light editing: fixed the script indentation (spot via flake8), I
removed the python2 tests as Python 2 is obsolete, and removed the space
between the (procedure)[area/conditional] part of the GNU changelog
commit messages.
Another note to help with review; when sending v2 patches, make sure the
title of your mail reply mentions [PATCH v2]; this helps to spot the
later versions in email threads.
The branch is shaping up nicely; I encourage you to try it. If no major
problem is found with it, I'll merge it in core-updates soon.
Thank you,
Maxim
[bug#45712] [PATCHES] Improve Python package quality, Maxim Cournoyer, 2021/01/25
[bug#45712] [PATCHES] Improve Python package quality, Maxim Cournoyer, 2021/01/25
[bug#45712] [PATCHES] Improve Python package quality, Maxim Cournoyer, 2021/01/29