[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#46699] [PATCH] gnu: mumble: Update to 1.3.4.
From: |
Leo Prikler |
Subject: |
[bug#46699] [PATCH] gnu: mumble: Update to 1.3.4. |
Date: |
Mon, 22 Feb 2021 20:28:37 +0100 |
User-agent: |
Evolution 3.34.2 |
Hi jgart,
Am Montag, den 22.02.2021, 19:09 +0000 schrieb jgart:
> Hi Leo,
>
> > IIRC, the correct tag would be Co-authored-by.
>
> I attached the updated patch with your suggestions.
>
> > These lines appear to be noise, some of them definitely are.
>
> Raghav thinks these might have been introduced by indent.el
>
> How would you suggest to remove them?
You can select the lines you actually wish to commit through `git
commit -p` or use any other tool to do the trick (e.g. Magit or gitg).
indent.el is a bit of a hammer. If you don't actively edit code, that
has wrong indentation, it's wiser to just indent your portions with
Emacs.
> > Are perl and ruby really required? If so, what for?
>
> They are for the 'patch-shebangs phase.
And why do you care about those shebangs? Are any of those programs
patched by that phase run at any point during build?
Regards,
Leo