guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#46680] [PATCH] gnu: Add midicomp.


From: Nicolas Goaziou
Subject: [bug#46680] [PATCH] gnu: Add midicomp.
Date: Tue, 23 Feb 2021 18:47:05 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Hello,

Alexandros Theodotou <alex@zrythm.org> writes:

> * gnu/packages/audio.scm (midicomp): New variable.

Thank you. Some comments follow.

> +    (package
> +      (name "midicomp")
> +      (version (string-append "0.0.6-" revision "." (string-take commit 7)))

According to the README, the last version is 0.0.8. Also, the above
should be written more compactly

  (version (git-version "0.0.8" revision commit))

> +      (synopsis "MIDI compiler")

I suggest "Convert SMF MIDI files to and from plain text", which may be
more explicit.

> +      (license license:agpl3))))

I think there is an issue here. The repository has no LICENSE file, and
source code files have no license header. The only reference to AGPL3.0
is in the README.md. I'm not sure this is sufficient.

WDYT?

Regards,
-- 
Nicolas Goaziou





reply via email to

[Prev in Thread] Current Thread [Next in Thread]