[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#46686] [PATCH] gnu: add libucl
From: |
Ludovic Courtès |
Subject: |
[bug#46686] [PATCH] gnu: add libucl |
Date: |
Sat, 06 Mar 2021 11:32:51 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
Hi,
qblade <qblade@protonmail.com> skribis:
> From aae95593f1cfd48c50578bec83927c870afc6bce Mon Sep 17 00:00:00 2001
> From: qblade <qblade@protonmail.com>
> Date: Sun, 21 Feb 2021 06:48:18 +0000
> Subject: [PATCH] gnu: add libucl
>
> * gnu/packages/config-lang.scm (libucl): New variable.
Thanks for the patch! It looks good to me, modulo the minor issues
below.
> gnu/packages/config-lang.scm | 54 ++++++++++++++++++++++++++++++++++++
Could you perhaps find another file to add it to, so we don’t have a
module for a single package? That said, I don’t have a good suggestion,
since ‘iniparser’ for instance is in samba.scm.
> + (synopsis "Universal configuration language")
> + (description "Universal configuration language.
> +fully compatible with JSON format and is able to parse json files")
Could you reword the description with full sentences, along the lines of:
https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html
Make sure to capitalize acronyms like JSON.
TIA,
Ludo’.
- [bug#46686] [PATCH] gnu: add libucl,
Ludovic Courtès <=