[bug#46699] [PATCH 1/2] gnu: mumble: Update to 1.3.4.

[jgart]

Hi Leo,

It is fine to close this bug.

Thank you for taking the time to review these changes and for merging the other 
patch. 

We'll keep CELT in mind going forward. Thank you for pointing that out.

all the best,

jgart

libremiami.org

March 6, 2021 12:38 PM, "Leo Prikler" <leo.prikler@student.tugraz.at> wrote:

> Am Samstag, den 06.03.2021, 17:35 +0100 schrieb Leo Prikler:
> 
>> Am Samstag, den 06.03.2021, 16:22 +0000 schrieb jgart:
>> Hi Leo,
>> 
>> These two patches change the logic in the snippet block from list
>> of
>> directories to delete to list of directories to keep as well as add
>> indentation to the mumble package. This is an addition to commit
>> ea13b3a14cb079e33b59cf60cdabf500ecc51cf1.
>> 
>> best regards,
>> 
>> jgart
>> Hi jgart,
>> 
>> 0001 suffers from similar issues as your previous patch set. In
>> particular, it adds a spurious level of indentation in arguments!
>> 0002 LGTM, I'll push it after some testing. On that note, could
>> someone investigate why we keep ancient versions of CELT around? It
>> seems newer ones have been merged into opus.
>> 
>> Regards,
>> Leo
> 
> I've now pushed 0002. As far as keeping ancient CELT, it seems version
> 1.4.0 will at least drop 0.11, while keeping 0.7 for backwards
> compatibility.
> 
> Do you want to keep this bug open for more indentation adjustments or
> is it fine to close?
> 
> Regards,
> Leo