guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#45889] Nextcloud Client (v16)


From: Raghav Gururajan
Subject: [bug#45889] Nextcloud Client (v16)
Date: Tue, 9 Mar 2021 05:50:43 -0500

Hi Leo!

Try not to arbitrarily use too many new lines.  If you break Scheme
code in such a manner for no good reason, it will look odd.

Done.

Why not to UTF-8?

Done.

You should install the shared libraries in the install phase.

Done.

Use '(...) for fixed input.

Done.

I'm starting to grow a little suspicious about matching the leading
spaces.  You probably want to lead this (and similar stuff in 0001)
with [ \t]*.

Done.

LGTM, but probably deserves a comment.

Done.

Definitely deserves a comment and perhaps a less broad match?

Done the comment.

I think this is perfect match. The mentioned libraries will get linked wherever synclib gets linked. Also, this patch is compatible with current master, which is different from this version.

Also deserves a comment about QtSingleApplication differences.

Done.

Would the raw string here exceed a line?

Yep!

This is now just qtokenizer, right?

Changed.

Please find the attached v16.

Regards,
RG.

Attachment: 0001-gnu-Add-appstream.patch
Description: Text Data

Attachment: 0002-gnu-Add-qtsolutions.patch
Description: Text Data

Attachment: 0003-gnu-Add-nextcloud-client.patch
Description: Text Data

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]