[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#47187] [PATCH] gnu: Add c-lightning.
From: |
Léo Le Bouter |
Subject: |
[bug#47187] [PATCH] gnu: Add c-lightning. |
Date: |
Tue, 16 Mar 2021 10:13:07 +0100 |
User-agent: |
Evolution 3.34.2 |
Hello!
Thanks for the patch!
I built it and it was successful, however, few comments:
The various hacks in the recipe to get a working build seem troublesome
maintenance-wise, is it possible you think since you are a developer
that you make the build scripts a bit more standard in the project?
I see there's some vendored libraries: gheap, jsmn, libbacktrace,
libsodium, libwally-core ; Is it possible to unvendor those and create
separate packages for each of them? Or is there a requirement of strict
behavior here, either way, you could also create separate packages for
each of them even if those are specific to c-lightning. It would make
the main recipe cleaner, since as far as I can see it's also why the
build system is so stubborn to GNU Guix? That it also attempts to build
vendored libraries?
Léo
signature.asc
Description: This is a digitally signed message part
- [bug#47187] [PATCH] gnu: Add c-lightning., ZmnSCPxj, 2021/03/16
- [bug#47187] [PATCH] gnu: Add c-lightning.,
Léo Le Bouter <=
- [bug#47187] [PATCH] gnu: Add c-lightning., Léo Le Bouter, 2021/03/16
- [bug#47187] [PATCH] gnu: Add c-lightning., ZmnSCPxj, 2021/03/16
- [bug#47187] [PATCH] gnu: Add c-lightning., Léo Le Bouter, 2021/03/16
- [bug#47187] [PATCH] gnu: Add c-lightning., ZmnSCPxj, 2021/03/16
- [bug#47187] [PATCH] gnu: Add c-lightning., Léo Le Bouter, 2021/03/18
- [bug#47187] [PATCH] gnu: Add c-lightning., ZmnSCPxj, 2021/03/18
- [bug#47187] [PATCH] gnu: Add c-lightning., Léo Le Bouter, 2021/03/19
- [bug#47187] [PATCH] gnu: Add c-lightning., ZmnSCPxj, 2021/03/19
- [bug#47187] [PATCH] gnu: Add c-lightning., Léo Le Bouter, 2021/03/21
- [bug#47187] [PATCH] gnu: Add c-lightning., Léo Le Bouter, 2021/03/26