guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#47730] [PATCH 4/4] gnu: Add watson.


From: Maxime Devos
Subject: [bug#47730] [PATCH 4/4] gnu: Add watson.
Date: Mon, 12 Apr 2021 21:42:08 +0200
User-agent: Evolution 3.34.2

On Mon, 2021-04-12 at 17:48 +0200, Sebastian Gibb via Guix-patches via wrote:
> [...]
> +     `(#:phases (modify-phases %standard-phases
> +                  (replace 'check
> +                    (lambda _
> +                      (invoke "pytest")
> +                      #t)))))

Phases do not need to return #t anymore.  The warning that results
if a phase doesn't return #t has been removed on the core-updates
branch, which will at some point in time be merged in master.

From a cursory look, I don't see any other problems, except perhaps ...

> +    (synopsis
> +     "Command-line time tracker")

I don't see a reason for a newline afer 'synopsis' here.

Thanks,
Maxime.

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]