guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#47822: [PATCH] gnu: Add r-naturalsort.


From: Roel Janssen
Subject: bug#47822: [PATCH] gnu: Add r-naturalsort.
Date: Tue, 04 May 2021 21:36:49 +0200
User-agent: Evolution 3.40.0 (3.40.0-1.fc34)

On Tue, 2021-05-04 at 12:31 -0400, Leo Famulari wrote:
> On Fri, Apr 16, 2021 at 12:57:51PM +0200, Roel Janssen wrote:
> > Here's a patch for r-naturalsort.
> > 
> > Also: is it OK to push patches like this ("another" fairly trivial
> > R
> > package) directly?
> 
> Yes. Quoting the manual section Commit Access:
> 
> ------
> For patches that just add a new package, and a simple one, it’s OK to
> commit, if you’re confident (which means you successfully built it in
> a
> chroot setup, and have done a reasonable copyright and license
> auditing). Likewise for package upgrades, except upgrades that
> trigger a
> lot of rebuilds (for example, upgrading GnuTLS or GLib). 
> ------
> 
> If you aren't feeling confident, just let us know what you'd like
> someone else to check for you. Otherwise, feel free to push.
> 

Thanks Efraim and Leo.  I pushed this patch in
aa7eeabe9a782afc2535581298990050d16b1895.

I will push trivial patches like these directly from now on.  Please do
let me know if I pushed something that would've benefitted from review.

Kind regards,
Roel Janssen






reply via email to

[Prev in Thread] Current Thread [Next in Thread]