[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#48233] [PATCH 1/3] guix-install.sh: Please the shellcheck linter.
|
From: |
Julien Lepiller |
|
Subject: |
[bug#48233] [PATCH 1/3] guix-install.sh: Please the shellcheck linter. |
|
Date: |
Wed, 05 May 2021 06:50:09 -0400 |
|
User-agent: |
K-9 Mail for Android |
Le 5 mai 2021 00:32:00 GMT-04:00, Maxim Cournoyer <maxim.cournoyer@gmail.com> a
écrit :
>
> wget --help | grep -q '\--show-progress' && \
> _PROGRESS_OPT="-q --show-progress" || _PROGRESS_OPT=""
>- wget $_PROGRESS_OPT -P "$dl_path" "${url}/${bin_ver}.tar.xz"
>"${url}/${bin_ver}.tar.xz.sig"
>
>- if [[ "$?" -eq 0 ]]; then
>- _msg "${PAS}download completed."
>+ if wget "$_PROGRESS_OPT" -P "$dl_path" \
>+ "${url}/${bin_ver}.tar.xz" "${url}/${bin_ver}.tar.xz.sig";
"$_PROGRESS_OPT" gets expanded to a single "-q --show-progress", which I doubt
exists in wget :). The previous version didn't have quotes.
Otherwise, LGTM.