[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#48501] [PATCH] daemon: Replace Unicode single quotes with poor simu
From: |
Thiago Jung Bauermann |
Subject: |
[bug#48501] [PATCH] daemon: Replace Unicode single quotes with poor simulacra. |
Date: |
Fri, 21 May 2021 11:23:20 -0300 |
Hello,
[ I'm just an onlooker on the Guix mailing lists, so don't assign much
weight to this comment. ]
Em terça-feira, 18 de maio de 2021, às 13:34:05 -03, Tobias Geerinckx-Rice
via Guix-patches via escreveu:
> The correct ‘ and ’ are not considered word boundaries by some(?)
> terminal emulators like Alacritty, making double-click selection
> tedious. Avoid them in untranslated strings like it's 1992.
>
> * nix/libstore/build.cc (UserLock::acquire)
> (DerivationGoal::haveDerivation, DerivationGoal::closureRepaired)
> (DerivationGoal::startBuilder, DerivationGoal::runChild)
> (DerivationGoal::registerOutputs): Replace ‘’ with `' in output.
> * nix/libstore/local-store.cc (canonicalisePathMetaData_)
> (LocalStore::queryValidPathId): Likewise.
> * nix/libstore/optimise-store.cc (LocalStore::optimisePath_): Likewise.
> * nix/libutil/util.cc (readLink): Likewise.
> ---
> nix/libstore/build.cc | 24 ++++++++++++------------
> nix/libstore/local-store.cc | 4 ++--
> nix/libstore/optimise-store.cc | 4 ++--
> nix/libutil/util.cc | 2 +-
> 4 files changed, 17 insertions(+), 17 deletions(-)
>
> diff --git a/nix/libstore/build.cc b/nix/libstore/build.cc
> index 5697ae5a43..d6f9a15a46 100644
> --- a/nix/libstore/build.cc
> +++ b/nix/libstore/build.cc
> @@ -525,7 +525,7 @@ void UserLock::acquire()
> int err = getgrouplist(pw->pw_name, pw->pw_gid,
> supplementaryGIDs.data(), &ngroups);
> if (err == -1)
> - throw Error(format("failed to get list of supplementary
> groups for ‘%1%’") % pw->pw_name); + throw
> Error(format("failed to get list of supplementary groups for `%1%’") %
> pw->pw_name);
IMHO the backtick looks ugly when it tries to mimick the opening quote
character. I think the text looks better if both quote characters are
replaced with the straight quote character, e.g. '%1'.
--
Regards from the peanut gallery,
Thiago