[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#48642] [PATCH] Add kanatest
From: |
Nicolò Balzarotti |
Subject: |
[bug#48642] [PATCH] Add kanatest |
Date: |
Tue, 25 May 2021 10:39:10 +0200 |
Hi! Thanks for the fast review!
Xinglu Chen <public@yoctocell.xyz> writes:
> On Tue, May 25 2021, Nicolò Balzarotti wrote:
>
>> +(define-public kanatest
>> + ;; Latest release tarball is 0.4.8, which is really old and does not build
>> + ;; commit on sourceforge are not tagged, we take the latest
>> + (let ((commit "860e790a35f547cc96669f805d371a5ba3d8daff"))
>> + (package
>> + (name "kanatest")
>> + (version (string-append "0.4.10." (string-take commit 7)))
>
> Use ‘(git-version VERSION REVISION COMMIT)’.
>
I added revision "0" along with commit in the let block and used
git-version as suggested.
>> [...]
>> + (home-page "https://kanatest.sourceforge.io/")
>
> Nit: ‘home-page’ usually comes before ‘synopsis’.
>
Moved above!
> Otherwise, LGTM! Builds fine as well.
Thanks, here's version 2 of the patch!
Thanks again for the review,
Nicolò
v2-0001-gnu-Add-kanatest.patch
Description: Text Data