guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#46955] [PATCH 3/3] gnu: python-cooler: Update to 0.8.11.


From: Maxime Devos
Subject: [bug#46955] [PATCH 3/3] gnu: python-cooler: Update to 0.8.11.
Date: Sat, 05 Jun 2021 12:06:01 +0200
User-agent: Evolution 3.34.2

A comment about a build phase.

> [...]
> +         (replace 'check
> +           (lambda _
> +             (invoke "python" "-m" "pytest" "-v")
> +            #t)))))

This needs to be something like

+ (replace 'check
+   (lambda* (#:key tests? #:allow-other-keys)
+     (when tests?
+       (invoke "python" "-m" "pytest" "-v"))))

By respecting 'tests?', the --without-tests build transformation can be used.
(Try "guix build python-cooler --without-tests=python-cooler").
This can also be important for cross-compilation (dunno if it applies here
though).

Trailing #t are not required anymore. The warning that results if it is removed
will disappear once core-updates is merged.

Greetings,
Maxime.

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]