[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#48889] [PATCH 1/4] New package: bird bgp daemon, versions 1 and 2
From: |
Maxime Devos |
Subject: |
[bug#48889] [PATCH 1/4] New package: bird bgp daemon, versions 1 and 2 |
Date: |
Mon, 07 Jun 2021 11:35:21 +0200 |
User-agent: |
Evolution 3.34.2 |
Hi,
Ryan Sundberg via Guix-patches via schreef op zo 06-06-2021 om 11:52 [-0700]:
> Adds the bird BGP daemon to gnu/packages/bird.scm
See commits (e.g. git log -n9) for how to format commit messages.
> ---
> gnu/packages/bird.scm | 74 +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 74 insertions(+)
> create mode 100644 gnu/packages/bird.scm
>
> diff --git a/gnu/packages/bird.scm b/gnu/packages/bird.scm
> new file mode 100644
> index 0000000000..5fac395906
> --- /dev/null
> +++ b/gnu/packages/bird.scm
Maybe gnu/packages/networking.scm, instead of creating a new
module for a single package.
> + #:phases (modify-phases %standard-phases
> + ; Fix "cc not found" in tools/mergedirs
> + (add-after 'bootstrap 'set-cc
> + (lambda _
> + (setenv "CPP" "gcc -E")
> + #t)))))
This most likely should be ,(string-append (cc-for-target) " -E"), to
make sure cross-compiling works. Also, the more declarative #:make-flags
is preferred above imperative setenv.
> + (inputs
> + `(("autoconf" ,autoconf)
> + ("bison" ,bison)
> + ("flex" ,flex)
autoconf, bison & flex most likely should be native inputs.
> + ("ncurses" ,ncurses)
> + ("readline" ,readline)))
> + (home-page "http://bird.network.cz/")
> + (synopsis "BIRD Internet Routing Daemon")
> + (description "The BIRD project aims to develop a dynamic IP routing
> daemon with full support of all modern routing protocols, easy to use
> configuration interface and powerful route filtering language, primarily
> targeted on (but not limited to) Linux and other UNIX-like systems and
> distributed under the GNU General Public License.")
> + (license gpl2+)))
The description line is too long.
./pre-inst-env guix lint bird@1.6.7 should detect that.
Greetings,
Maxime.
signature.asc
Description: This is a digitally signed message part