[bug#49025] [PATCH v5 01/20] utils: Define target-linux? predicate.

[Mathieu Othacehe]

Hey,

> +(define* (target-linux? #:optional (target (or (%current-target-system)
> +                                               (%current-system))))

You can add a docstring here, something like:

  "Is the operating system of TARGET Linux?"

> +  (string-contains target "linux"))

You should use the "->bool" procedure to return a boolean here.

>  (define* (target-mingw? #:optional (target (%current-target-system)))

You can add a docstring, something like:

  "Is the operating system of TARGET Windows 32 bits?"

> +  (map (compose ->bool target-linux?)

target-linux? should return a boolean

> +(test-equal "target-mingw?"
> +  '(#f #f #t)
> +  (map (compose ->bool target-mingw?)

You can write:

--8<---------------cut here---------------start------------->8---
  (map target-mingw?
       '("i686-linux-gnu" "i686-pc-gnu" "i686-w64-mingw32")))
--8<---------------cut here---------------end--------------->8---

here.

Thanks,

Mathieu