[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#49547] [PATCH v2 2/4] home-services: Add home-run-on-change-service
From: |
Maxime Devos |
Subject: |
[bug#49547] [PATCH v2 2/4] home-services: Add home-run-on-change-service-type |
Date: |
Sun, 18 Jul 2021 18:17:31 +0200 |
User-agent: |
Evolution 3.34.2 |
Andrew Tropin schreef op do 15-07-2021 om 11:46 [+0300]:
> No specific reason. Yep, spawning a new process can be expensive, but
> it's not clear how much time will take the comparison itself and if it
> worth it to optimize "startup time". I'm not very fluent with guile
> internals and not sure if reimplementation of cmp in guile would improve
> or worsen the performance, but it obviously could intoduce some bugs. I
> found Xinglu's idea of the usage of well-tested cmp to be a reasonable
> solution here.
Sounds reasonable to me.
> Also, this service is expected to be used with small amount of files and
> because many of them are symlinks to the store even smaller number of
> them will trigger the execution of cmp, so I find the performance
> optimization to be preliminary here and propose to address the issue
> when and if it appear someday.
>
> However, the ideas about size and inodes are good, easy to implement and
> I find them potentially useful to prevent unecessary external process
> spawning. The patch with those improvements are below: [...]
Greetings,
Maxime.
signature.asc
Description: This is a digitally signed message part
- [bug#49419] [PATCH 2/4] home-services: Add home-run-on-change-service-type, (continued)
- [bug#49419] [PATCH 2/4] home-services: Add home-run-on-change-service-type, Andrew Tropin, 2021/07/05
- [bug#49419] [PATCH 3/4] home-services: Add home-provenance-service-type, Andrew Tropin, 2021/07/05
- [bug#49419] [PATCH 4/4] home-services: Add fold-home-service-types function, Andrew Tropin, 2021/07/05
- [bug#49419] [PATCH v2 0/4] Essential home services, Andrew Tropin, 2021/07/13
- [bug#49547] [PATCH v2 2/4] home-services: Add home-run-on-change-service-type, Andrew Tropin, 2021/07/13
[bug#49549] [PATCH v2 4/4] home-services: Add fold-home-service-types function, Andrew Tropin, 2021/07/13
[bug#49568] Testing reply without debbugs address, Andrew Tropin, 2021/07/15
[bug#49419] [PATCH v3 0/4] Essential home services, Andrew Tropin, 2021/07/19
- [bug#49419] [PATCH v3 4/4] home-services: Add fold-home-service-types function, Andrew Tropin, 2021/07/19
- [bug#49419] [PATCH v3 1/4] home-services: Add most essential home services, Andrew Tropin, 2021/07/19
- [bug#49419] [PATCH v3 3/4] home-services: Add home-provenance-service-type, Andrew Tropin, 2021/07/19
- [bug#49419] [PATCH v3 2/4] home-services: Add home-run-on-change-service-type, Andrew Tropin, 2021/07/19
- [bug#49419] [PATCH 0/4] Essential home services, Ludovic Courtès, 2021/07/21