[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#49471] [PATCH] gnu: lld: Update to 12.0.0.
From: |
Ludovic Courtès |
Subject: |
[bug#49471] [PATCH] gnu: lld: Update to 12.0.0. |
Date: |
Mon, 19 Jul 2021 19:37:28 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hi,
Leo Prikler <leo.prikler@student.tugraz.at> skribis:
> * gnu/packages/llvm.scm (llvm-subprojects-origin, %llvm-project-12.0.0-hash):
> New variables.
> (lld-11, lld-12): New variables.
> (lld): Point to lld-11.
> ---
> This patch is an alternative to the one sent by terramorpha.
>
> Supposed advantages of it are:
> * lld still points to lld-11, not breaking any packages that rely on it
> * llvm-subprojects-origin can be reused by other LLVM subprojects
> (think of libcxx and libcxxabi, which both require each other, or
> libunwind, which requires libcxx)
>
> Disadvantages are:
> * llvm-project is a beefy tarball and somewhat of a pain to unpack
> * Both this version and the original use an unclean approach to building
> subprojects, that is propagated by LLVM. Perhaps we ought to instead
> clean up their mess?
I’m not sure that the 2nd point means, but perhaps it can be addressed
separately?
> -(define-public lld
> +(define-public lld-11
> (package
> (name "lld")
> (version "11.0.0")
Does it make sense to keep old versions of the linker around? To me
it’s much less useful than keeping old versions of the compiler.
> +(define %llvm-project-12.0.0-hash
> "0a1n88dmbwp1ww7h3ykf0s001cndk1bm3i2cj1y2sh548f4nilcy")
^
I’d use ‘base32’ here (for expansion-time base32 decoding) and remove it
from ‘llvm-subprojects-origin’.
Otherwise LGTM.
Thanks!
Ludo’.