[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#49281] Add dynaconf

From: Sarah Morgensen
Subject: [bug#49281] Add dynaconf
Date: Thu, 22 Jul 2021 23:14:36 -0700


Thanks for the patches :) The fight against vendoring is eternal.

I have a few suggestions:

* Unvendoring or otherwise removing files from sources is typically done
  with a snippet in the origin rather than a patch, as it's much smaller
  and doesn't break when updating. It might look like (untested):

  (modules '((guix build utils)))
      ;; Remove vendored dependencies
      (let ((unvendor '("click" "dotenv" "ruamel" "toml")))
        (with-directory-excursion "dynaconf/vendor"
          (for-each delete-file-recursively unvendor))
        (with-directory-excursion "dynaconf/vendor_src"
          (for-each delete-file-recursively unvendor))))))

  You'll still have to have the edits to dynaconf as a patch, of course.

* You've still included a python-box package despite none of the
  packages in your patch using it.

* pep8-naming has released 12.0.0, and tests pass :)

* Some of your patches no longer apply on master, and you should rebase
  them before sending a revised patchset. Consider using the `--base`
  option with format-patch, which helps git know what commit the patch
  is based on when applying.

paul <> writes:

> Hi Guixers :),
> I'm sending a patch series to add dynaconf.
> Thank you for your time,
> Giacomo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]