guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#50084] [PATCH] gnu: Add waypipe.


From: Maxime Devos
Subject: [bug#50084] [PATCH] gnu: Add waypipe.
Date: Tue, 07 Sep 2021 23:13:04 +0200
User-agent: Evolution 3.34.2

Hi,

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'fix-sleep-path
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             (let ((coreutils (assoc-ref inputs "coreutils")))

coreutils is in native-inputs, not inputs, so this needs to be:
(assoc-ref (or native-inputs inputs) "coreutils").  (native-inputs
and inputs are appended together when compiling natively, that's
why this didn't cause a build error).

> +               (substitute* "./test/startup_failure.py"
> +                 (("sleep") (string-append coreutils "/bin/sleep")))))))))

You can write (("sleep") (which "sleep")) here.

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("scdoc" ,scdoc)
> +       ;; For tests
> +       ("python" ,python)
> +       ("coreutils" ,coreutils)))

FWIW, coreutils is an implicit native-input of meson-build-system,
so this input isn't necessary.

Greetings,
Maxime.

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]