[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#51346] [PATCH 0/1 core-updates-frozen] Rework swap device to add de
From: |
Ludovic Courtès |
Subject: |
[bug#51346] [PATCH 0/1 core-updates-frozen] Rework swap device to add dependencies and flags |
Date: |
Mon, 15 Nov 2021 12:04:24 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Josselin Poiret <dev@jpoiret.xyz> skribis:
> + (lambda (swap)
> + (define requirements
> + (cond ((swap-space? swap)
> + (map dependency->shepherd-service-name
> + (swap-space-dependencies swap)))
> + ; TODO Remove after deprecation
> + ((and (string? swap) (string-prefix? "/dev/mapper/" swap))
> + (list (symbol-append 'device-mapping-
> + (string->symbol (basename swap)))))
BTW, shouldn’t we emit a deprecation warning when (string? swap)?
If we do, it should contain source location info, as discussed at
<https://lists.gnu.org/archive/html/guix-devel/2021-09/msg00314.html>.
The whole series LGTM modulo the minor issues I commented on; could you
send a last version?
If Tobias agrees, we can apply that last version as soon as we get it.
I’d even apply it to ‘master’; why did you target ‘core-updates-frozen’?
Thanks!
Ludo’.
- [bug#51346] [PATCH 0/1 core-updates-frozen] Rework swap device to add dependencies and flags, Ludovic Courtès, 2021/11/15
- [bug#51346] [PATCH 0/1 core-updates-frozen] Rework swap device to add dependencies and flags, Ludovic Courtès, 2021/11/15
- [bug#51346] [PATCH 0/1 core-updates-frozen] Rework swap device to add dependencies and flags, Ludovic Courtès, 2021/11/15
- [bug#51346] [PATCH 0/1 core-updates-frozen] Rework swap device to add dependencies and flags,
Ludovic Courtès <=
- [bug#51346] [PATCH v3 0/5] Rework swap device to add dependencies and flags, Josselin Poiret, 2021/11/15
- [bug#51346] [PATCH v3 1/5] gnu: system: Rework swap space support, add dependencies., Josselin Poiret, 2021/11/15
- [bug#51346] [PATCH v3 2/5] gnu: system: Warn about swap-devices format change, Josselin Poiret, 2021/11/15
- [bug#51346] [PATCH v3 3/5] gnu: system: Add swap flags., Josselin Poiret, 2021/11/15
- [bug#51346] [PATCH v3 4/5] gnu: system: Filter out boot dependencies from swap-space., Josselin Poiret, 2021/11/15
- [bug#51346] [PATCH v3 5/5] doc: Add new Swap Space section., Josselin Poiret, 2021/11/15
- bug#51346: [PATCH 0/1 core-updates-frozen] Rework swap device to add dependencies and flags, Ludovic Courtès, 2021/11/23