[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#51967] [PATCH] gnu: Add gsimplecal
From: |
Jaft |
Subject: |
[bug#51967] [PATCH] gnu: Add gsimplecal |
Date: |
Sat, 20 Nov 2021 00:46:31 +0000 (UTC) |
> On Friday, November 19, 2021, 01:55:44 PM CST, Liliana Marie Prikler
> <liliana.prikler@gmail.com> wrote:
>
>
>
>
>
> Hi,
>
> Am Freitag, den 19.11.2021, 08:48 +0000 schrieb Jaft:
> > Hello; this is my first patch so, if I've missed or forgotten
> > anything, just let me know and I'm happy to get it fixed.
> First things first: transmit plain text, not HTML.
>
> Second, only the topmost directory (gnu:, guix:, doc:) is usually
> important. Package additions follow the rule "gnu: Add PACKAGE".
>
> > * gnu/packages/calendar.scm (gsimplecal): Add gsimplecal to Guix for
> > the first time, sourced from git.
> Simply say "New variable".
>
> > ---
> This line marks where you can add comments when you transmit the patch
> as-is. You might want to use it in lieu of a pre-statement.
>
> > gnu/packages/calendar.scm | 30 ++++++++++++++++++++++++++++++
> > 1 file changed, 30 insertions(+)
> >
> > diff --git a/gnu/packages/calendar.scm b/gnu/packages/calendar.scm
> > index 8ec36d4fa2..4c54ac0549 100644
> > --- a/gnu/packages/calendar.scm
> > +++ b/gnu/packages/calendar.scm
> > @@ -10,6 +10,7 @@
> > ;;; Copyright © 2020 Brendan Tildesley <mail@brendan.scot>
> > ;;; Copyright © 2020 Tanguy Le Carrour <tanguy@bioneland.org>
> > ;;; Copyright © 2020 Peng Mei Yu <pengmeiyu@riseup.net>
> > +;;; Copyright © 2021 Wamm K. D. <jaft.r@outlook.com>
> > ;;;
> > ;;; This file is part of GNU Guix.
> > ;;;
> > @@ -36,6 +37,7 @@ (define-module (gnu packages calendar)
> > #:use-module (guix build-system cmake)
> > #:use-module (guix build-system python)
> > #:use-module (gnu packages admin)
> > + #:use-module (gnu packages autotools)
> > #:use-module (gnu packages base)
> > #:use-module (gnu packages check)
> > #:use-module (gnu packages dav)
> > @@ -405,3 +407,31 @@ (define-public ccal
> > ;; COPYING.LESSER specifies LGPL 3.0, but all source files say
> > ;; 'Lesser GPL version 2 or later'.
> > (license (list license:gpl2+ license:lgpl2.1+))))
> > +
> > +(define-public gsimplecal
> > + (let ([commit "f00b80d86300397b52c3cf7d8dfc8de5cdee921d"]
> > + [revision "1"])
> Guile is not racket, it's round brackets everywhere.
Guile doesn't allow square brackets, like Racket does? I don't think I've ever
found that to be the case. I know at least some of the RnRS standards don't
allow it but I didn't think Guile was a strict adherent. Not that I'm pushing
back since, clearly, it falls outside the style guide for Guix but it's the
first I've heard that Guile requires parentheses everywhere.
> We also don't do right alignment. A simple space between
> variable/field and value is enough.
> > + (package
> > + (name "gsimplecal")
> As above, pp.
> > + (version (git-version "2.2" revision commit))
> > + (source (origin
> > + (method git-fetch)
> > + (uri (git-reference
> > + (url "
> > https://github.com/dmedvinsky/gsimplecal/")
> > + (commit
> > commit)))
> > + (file-name (git-file-name name version))
> > + (sha256 (base32 (string-append/shared
> > +
> > "1qyf65l088dqsz25hm6s1cv18j"
> > +
> > "52yaias0llqvpqwjfnvssa5cxg")))
> Use a single string rather than a function call.
> > + (modules '((guix build utils)))))
> > + (build-system gnu-build-system)
> > + (native-inputs `(("autoconf" ,autoconf)
> > + ("automake" ,automake)
> > + ("pkg-config" ,pkg-config)
> > + ("gtk+" ,gtk+)))
> GTK+ is probably not a native-input. Also use a newline here.
Ah, whoops; 'thought I'd put that as just an input, before…
> > + (home-page "https://dmedvinsky.github.io/gsimplecal/")
> > + (synopsis "Lightweight calendar applet written in C++
> > using GTK")
> > + (description "Gsimplecal was intentionally made for use with
> > tint2 panel
> > +in the openbox environment to be launched upon clock click but, of
> > course, it
> > +will work without it.")
> That's... not very descriptive, is it?
I was using the description provided by the author on their GitHub site; should
I come up with my own description, in my own words, instead? The synopsis
already pretty much covers what it is (a calendar applet so a calendar pops up
when activated; a GTK simple calendar) so I figured that, combined, they gave a
good snapshot of what it is and what it's aiming for.
But I can definitely alter it to something else if that isn't sufficient; just
double checking so let me know and I shall do that.
>
> > + (license license:bsd-3))))
>
>
> Thanks for the submission and happy hacking :)
Sure thing! I've attached what I have, so far, for the updated patch, below,
and I'll update it again if the description needs tweaking.
* gnu/packages/calendar.scm (gsimplecal): New variable
---
gnu/packages/calendar.scm | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/gnu/packages/calendar.scm b/gnu/packages/calendar.scm
index 8ec36d4fa2..3c61a109a3 100644
--- a/gnu/packages/calendar.scm
+++ b/gnu/packages/calendar.scm
@@ -10,6 +10,7 @@
;;; Copyright © 2020 Brendan Tildesley <mail@brendan.scot>
;;; Copyright © 2020 Tanguy Le Carrour <tanguy@bioneland.org>
;;; Copyright © 2020 Peng Mei Yu <pengmeiyu@riseup.net>
+;;; Copyright © 2021 Wamm K. D. <jaft.r@outlook.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -36,6 +37,7 @@ (define-module (gnu packages calendar)
#:use-module (guix build-system cmake)
#:use-module (guix build-system python)
#:use-module (gnu packages admin)
+ #:use-module (gnu packages autotools)
#:use-module (gnu packages base)
#:use-module (gnu packages check)
#:use-module (gnu packages dav)
@@ -405,3 +407,32 @@ (define-public ccal
;; COPYING.LESSER specifies LGPL 3.0, but all source files say
;; 'Lesser GPL version 2 or later'.
(license (list license:gpl2+ license:lgpl2.1+))))
+
+(define-public gsimplecal
+ (let ((commit "f00b80d86300397b52c3cf7d8dfc8de5cdee921d")
+ (revision "1"))
+ (package
+ (name "gsimplecal")
+ (version (git-version "2.2" revision commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/dmedvinsky/gsimplecal/")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256 (base32 (string-append/shared
+ "1qyf65l088dqsz25hm6s1cv18j"
+ "52yaias0llqvpqwjfnvssa5cxg")))
+ (modules '((guix build utils)))))
+ (build-system gnu-build-system)
+ (native-inputs
+ `(("autoconf" ,autoconf)
+ ("automake" ,automake)
+ ("pkg-config" ,pkg-config)))
+ (inputs `(("gtk+" ,gtk+)))
+ (home-page "https://dmedvinsky.github.io/gsimplecal/")
+ (synopsis "Lightweight calendar applet written in C++ using GTK")
+ (description "Gsimplecal was intentionally made for use with tint2 panel
+in the openbox environment to be launched upon clock click but, of course, it
+will work without it.")
+ (license license:bsd-3))))