bug#52066: [PATCH, core-updates-frozen, RFC] Fix static guile on aarch64

[Pierre Langlois]

Hi Ludo',

Ludovic Courtès <ludo@gnu.org> writes:

> Hi Pierre,
>
> Pierre Langlois <pierre.langlois@gmx.com> skribis:
>
>> The root of the issue seems to be that the make-guile-static procedure
>> isn't actually producing a static binary on aarch64.  Digging into it
>> more, we do pass the -all-static flag to libtool, but the gcc command
>> doesn't actually do any static linking:
>>
>> /tmp/guix-build-guile-static-3.0.7.drv-0/guile-3.0.7$ make V=1
>> ...
>> ../libtool  --tag=CC   --mode=link gcc -std=gnu11 -pthread -Wall 
>> -Wmissing-prototypes -Wpointer-arith -fno-strict-aliasing -fwrapv 
>> -fvisibility=hidden -g -O2 -all-static -pthread -ldl -o guile guile-guile.o 
>> libguile-3.0.la -ldl -lcrypt  -lm
>> libtool: link: gcc -std=gnu11 -pthread -Wall -Wmissing-prototypes
>> -Wpointer-arith -fno-strict-aliasing -fwrapv -fvisibility=hidden -g -O2
>> -pthread -o guile guile-guile.o ./.libs/libguile-3.0.a
>> -L/gnu/store/3539zsmc939g1r9g3r02bpy0m1b9v9c8-libgc-8.0.4/lib
>> -L/gnu/store/sn95w7yk9qwxhw74l590606y53pf5mkf-libffi-3.3/lib
>> /gnu/store/3539zsmc939g1r9g3r02bpy0m1b9v9c8-libgc-8.0.4/lib/libgc.a -lpthread
>> /gnu/store/sn95w7yk9qwxhw74l590606y53pf5mkf-libffi-3.3/lib/libffi.a
>> -lunistring -ldl -lcrypt -lm -pthread
>
> So ‘libtool’ is not passing ‘-static’, right?  Why is that?  (It does
> pick .a libs though.)

Yeah, I'm also confused about that.  I did take a quick look at the
libtool sources but I couldn't work out what was happening.  My best
guess is that it tries to use the -static flag and fails, but it prefer
to drop the flag rather than issue an error.  It could be for backwards
compatiblity reasons.

>
> [...]
>
>> Doing more digging, I found a reference to a similar issue here:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1830472#c1, this looks
>> related to the -moutline-atomics option that's enabled by default with
>> GCC 10.  But we're building guile with GCC 7 so it was a bit confusing.
>>
>> However, glibc here is actually built with the default GCC 10, and if we
>> change that then it works!
>>
>> --- a/gnu/packages/make-bootstrap.scm
>> +++ b/gnu/packages/make-bootstrap.scm
>> @@ -85,6 +85,9 @@ (define glibc-for-bootstrap
>>            `(cons* "--disable-nscd" "--disable-build-nscd"
>>                    "--enable-static-nss"
>>                    ,flags))))
>> +      (native-inputs
>> +       `(("gcc" ,gcc-7)
>> +         ,@(package-native-inputs base)))
>>  
>>        ;; Remove the 'debug' output to allow bit-reproducible builds (when 
>> the
>>        ;; 'debug' output is used, ELF files end up with a .gnu_debuglink, 
>> which
>
> I think that’s a reasonable fix for now; you can push the patch.
>
> However, we should eventually switch to GCC 10 in make-bootstrap.scm; I
> don’t think there’s any good justification for sticking to GCC 7.
>
> Thank you!

Thanks! I just pushed it with as
48b754553aeb98660fe145633616a9d965fbd60e.

Pierre

signature.asc
Description: PGP signature