guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#52189] [PATCH] gnu: Add notcurses


From: Blake Shaw
Subject: [bug#52189] [PATCH] gnu: Add notcurses
Date: Fri, 03 Dec 2021 04:04:15 +0700

Hi Nicolas,

Thanks for the review.

> I don't think we should create a new file just for this package. Also,
> new files need to be registered in "gnu/local.mk".

> Maybe this should go into... "ncurses.scm" (!). At a later time, we may
> rename ncurse.scm into tui.scm or some such.

When I asked about where it should go in the IRC, specifically inquiring
if it should be placed with ncurses, <notmaximed> said that it shouldn't
go with Ncurses and it should be placed in its own file [1]. Are we now
sure that the opposite is the case? noted re: `gnu/local.mk` for the future. 

> Upstream use tags. It might be more readable. You'll need a variable for
> the code name, tho. In any case, a comment is warranted explaining the
> situation.

> Nitpick: string should go on the same line as base32.

Noted.

> The build-type value above is suspicious.

It is recommended to set this value in `INSTALL.md`. What about it is 
suspicious?

> This is not cross-compilation friendly.

Noted. I'll change it and try running it on other architectures using
QEMU, I had tried without success before; hopefully that will get it
building faithfully across platforms :)

> Is the phase above required for tests? If so, could you add a comment
> about it?

The configure flags are set to build a slimmed down version of
Notcurses; it shaves about 80mb off. I had hoped to make different
outputs with different options, but when I asked about it in IRC I
didn't get a response, and couldn't find any package that is
configurable based on outputs to reference.

I just checked and the phase configuration can go entirely actually, I
just checked. But the build will fail without the configure flags set.

But alas, I just found out the 3.0 release was yesterday, which is
said to be a big improvement on many levels, so it seems like I should
just go ahead and build that one now with your suggestions and introduce
the package from this version. This package has been driving me crazy
tbh, because it updates nearly everytime I prepare to send it up
stream. but I was under the impression the 3.0 wouldn't be ready until
maybe 2022.   

[1] https://logs.guix.gnu.org/guix/2021-10-24.log#201806

Thanks for the feedback and let me know about the above questions and
I'll send the new patch accordingly.

Best,
Blake

-- 
“In girum imus nocte et consumimur igni”





reply via email to

[Prev in Thread] Current Thread [Next in Thread]