[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#51747] [PATCH]: gnu: nix: Update to 2.4.
From: |
Maxime Devos |
Subject: |
[bug#51747] [PATCH]: gnu: nix: Update to 2.4. |
Date: |
Fri, 14 Jan 2022 13:56:25 +0100 |
User-agent: |
Evolution 3.38.3-1 |
Zhu Zihao schreef op vr 14-01-2022 om 17:31 [+0800]:
> [...]
> +(define-public libcpuid
> + (let ((commit "2e61160983f32ba840b2246d3c3850c44626ab0d")
> + (revision "1"))
> + (package
> + (name "libcpuid")
> + (version (git-version "0.5.1" revision commit))
There's a good reason for using an unreleases version here,
but this should ideally be documented with a comment,
maybe
;; See <https://github.com/anrieff/libcpuid/pull/159>
> + (source
> + (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/anrieff/libcpuid")
> + (commit commit)))
> + (sha256
> + (base32
> "1mphvkiqq6z33sq6i490fq27sbyylacwrf8bg7ccvpcjms208sww"))
> + (modules '((guix build utils)))
> + (snippet
> + ;; Remove blobs
> + #~(begin
> + (delete-file "libcpuid/msrdriver.c")
> + (delete-file-recursively "contrib/MSR Driver")))
> + (file-name (git-file-name name version))))
> + (build-system cmake-build-system)
> + (arguments
> + (list #:tests? #f)) ;broken
In which manner are they broken? Maybe they can be fised.
> + (supported-systems '("x86_64-linux" "i686-linux"))
See my e-mail about target-x86-64? and the Hurd.
> + (home-page "https://libcpuid.sourceforge.net/")
> + (synopsis "Small library for x86 CPU detection and feature
> extraction")
> + (description "Libcpuid is a small C library to get vendor,
> model, branding
> +string, code name and other information from x86 CPU.")
It seems easy to confuse this with the package 'cpuid', maybe you
can mention 'cpuid' and 'libcpuid' are unrelated packages, albeit
for a similar purpose?
Greetings,
Maxime.
signature.asc
Description: This is a digitally signed message part
- [bug#51747] [PATCH]: gnu: nix: Update to 2.4., (continued)
- [bug#51747] [PATCH]: gnu: nix: Update to 2.4., Zhu Zihao, 2022/01/14
- [bug#51747] [PATCH]: gnu: nix: Update to 2.4., Maxime Devos, 2022/01/14
- [bug#51747] [PATCH]: gnu: nix: Update to 2.4., Zhu Zihao, 2022/01/14
- [bug#51747] [PATCH]: gnu: nix: Update to 2.4., Zhu Zihao, 2022/01/15
- [bug#51747] [PATCH]: gnu: nix: Update to 2.4., Maxime Devos, 2022/01/15
- [bug#51747] [PATCH]: gnu: nix: Update to 2.4., Zhu Zihao, 2022/01/15
- bug#51747: [PATCH]: gnu: nix: Update to 2.4., Oleg Pykhalov, 2022/01/21
- [bug#51747] [PATCH]: gnu: nix: Update to 2.4., Maxime Devos, 2022/01/23
[bug#51747] [PATCH]: gnu: nix: Update to 2.4., Maxime Devos, 2022/01/11
[bug#51747] [PATCH]: gnu: nix: Update to 2.4., Zhu Zihao, 2022/01/14
- [bug#51747] [PATCH]: gnu: nix: Update to 2.4.,
Maxime Devos <=