guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#53015] [PATCH 2/4] gnu: spdlog: Build with '-fpic'.


From: John Kehayias
Subject: [bug#53015] [PATCH 2/4] gnu: spdlog: Build with '-fpic'.
Date: Sat, 22 Jan 2022 05:06:17 +0000

Hello,

This patch (2/4 build option for spdlog, part of the MangoHud patch series) may 
be superseded by 
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=b1542d59606919d0da04914fa6916b85354e2f89
  (CCing Nicolas, hope that's okay!) I've built MangoHud with the shared spdlog 
before, seems to work.

However, given what spdlog has in its documentation, I wonder if it would be 
better to default to the static version as before? I think the "-fpic" build 
option would also work for shared linking in general? Or does that not work for 
nheko, which this change was for I believe?

I'm not really sure though, nor have a strong opinion, just going based on 
spdlog's info and that some projects (like MangoHud) build spdlog as a static 
library by default when bundling. I'm guessing it is for performance reasons, 
though I don't know if that is realized.

John





reply via email to

[Prev in Thread] Current Thread [Next in Thread]