[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#53879] [PATCH] gnu: Add emacs-everywhere.
From: |
Nicolas Goaziou |
Subject: |
[bug#53879] [PATCH] gnu: Add emacs-everywhere. |
Date: |
Tue, 08 Feb 2022 18:29:27 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Hello,
Jai Vetrivelan <jaivetrivelan@gmail.com> writes:
> Subject: [PATCH] gnu: Add emacs-everywhere.
Thanks. Some comments follow.
> +(define-public emacs-everywhere
> + ;; No upstream release. Extract version from main file.
> + (let ((revision "0") (version "0.0.1")
Nitpick: binding should go to separate lines. However, in this case,
I suggest to move version string right in the "version" field. It will
make life of the updater scripts easier.
> + (propagated-inputs
> + (list xclip xdotool xprop xwininfo))
Could you turn those into regular inputs, and patch calls in the
library? Ideally, upstream should turn the location of these executables
into a defcustom. You may want to suggest it to them.
Regards,
--
Nicolas Goaziou