guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#54021] [PATCH] Add rhino javascript package


From: Maxime Devos
Subject: [bug#54021] [PATCH] Add rhino javascript package
Date: Wed, 16 Feb 2022 18:00:20 +0100
User-agent: Evolution 3.38.3-1

Frank Pursel schreef op di 15-02-2022 om 17:58 [-0800]:
> +                        (if tests?
> +                            (setenv "ANT_OPTS" "-Doffline=true")
> +                            (invoke "ant" "junit")) #t))

This does 'setenv' when tests?, and runs "ant junit" when (not tests?),
which doesn't seem useful.

Did you mean

  (when tests?
    (setenv ...)
    (invoke ...))

instead?  Also, you can drop the trailing #t, while they used to be
necessary, they don't have a meaning anymore and are gradually removed
from existing packages.

Greetings,
Maxime.

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]